Expand Minimize

Use inline array annotation for dependency injection in filters

Use inline array annotation for dependency injection in filters

CheckId NG1120601
TypeName UseInlineArrayAnnotationForDIInFilters
Severity CriticalWarning
Type Filter

Using inline array annotation for dependency injection improves the performance of AngularJS injecting dependencies into these functions as it doesn't need to dynamically discover these functions' dependencies.

Good practice

function relativeUrl($rootScope) {
    // ...
}

angular.module('app')
    .filter('relativeUrl', ['$rootScope', relativeUrl]);


Bad practice
function relativeUrl($rootScope) {
    // ...
}

angular.module('app')
    .filter('relativeUrl', relativeUrl);    

Disclaimer: The views and opinions expressed in this documentation and in SPCAF do not necessarily reflect the opinions and recommendations of Microsoft or any member of Microsoft. SPCAF and RENCORE are registered trademarks of Rencore. All other trademarks, service marks, collective marks, copyrights, registered names, and marks used or cited by this documentation are the property of their respective owners.