Expand Minimize

SPC059007: Consider verifying that the user has sufficient permissions when calling List.Update()

Before updating a List object, consider making sure the user has permissions to perform that action.

CheckId SPC059007
TypeName CheckHasListPermissionsBeforeUpdate
Severity Warning
Type Assembly

Bad Practice

using (ClientContext context = new ClientContext("http://yoursite"))
{
    Web web = context.Web;
    List list = web.Lists.GetByTitle("MyCustomerList");
    list.Title = "My New Customer List Title";
    list.Update();
    context.ExecuteQuery();
}

Good Practice
using (ClientContext context = new ClientContext("http://yoursite"))
{
    Web web = context.Web;
    List list = web.Lists.GetByTitle("MyCustomerList");

    BasePermissions permissions = new BasePermissions();
    permissions.Set(PermissionKind.ManageLists);

    var permissionResults = web.DoesUserHavePermissions(permissions);
    context.ExecuteQuery();

    if (permissionResults.Value)
    {
        list.Title = "My New Customer List Title";
        list.Update();
        context.ExecuteQuery();
    }
}

To suppress this violation in managed code add the following attribute to the method which contains the instruction (available since SPCAF version v5.2). Learn more about SuppressMessage here.

// Important: Ensure to have #define CODE_ANALYSIS at the beginning of your .cs file
[SuppressMessage("SPCAF.Rules.ManagedCSOM.CSOMBestPracticesGroup", "SPC059007:CheckHasListPermissionsBeforeUpdate", Justification = "Provide reason for suppression here")]
Disclaimer: The views and opinions expressed in this documentation and in SPCAF do not necessarily reflect the opinions and recommendations of Microsoft or any member of Microsoft. SPCAF and RENCORE are registered trademarks of Rencore. All other trademarks, service marks, collective marks, copyrights, registered names, and marks used or cited by this documentation are the property of their respective owners.